I thought there was one of these threads already but I couldn't find it.
I have an 80G iPod Classic that I got as a present from my ex for my 21st. I suppose as far as mp3 players go it probably suits me the best. The sound quality might be a bit inferior but there's very few mp3 players on the market with that amount of storage capacity. I'd prefer to have most of my collection stores on it rather than having the hassle of swapping files whenever I want to change the music stored on it.
I also have one of these little IItronics mp3 players
The storage capacity is only 512MB but the sound quality is actually better than the iPod. They're handy just to have in your pocket when you're walking around town.